Add interview group forms #1573
Conversation
There was a problem hiding this comment.
Se kommentarer. Syns generel "naming" av koseptet burde endres. Tror det gir mer mening å gp ut i fra at det er en gruppe med stillinger som har ett delt inverju. Dermed blir det noe sånn som PositionsSharedInterview. Har kommentert i views.py, men det vil også kreve at man endrer på "naming" andre plasser hvor det refereres til shared interview.
backend/samfundet/views.py
Outdated
| @@ -633,6 +633,13 @@ class RecruitmentForRecruiterView(ModelViewSet): | |||
| queryset = Recruitment.objects.all() | |||
|
|
|||
|
|
|||
| @method_decorator(ensure_csrf_cookie, 'dispatch') | |||
| class RecruitmentSharedInterviewGroupView(ModelViewSet): | |||
There was a problem hiding this comment.
Kunne man kalt dette noe annet? Er det ikke snakk om en "gruppe" med stillinger som har delt intervju, så kanskje: RecruitmentSharedInterviewPositionsView
There was a problem hiding this comment.
og da det samme med modellen RecruitmentPositionsSharedInterviewGroup blir RecruitmentSharedInterviewPositions
| @method_decorator(ensure_csrf_cookie, 'dispatch') | ||
| class RecruitmentSharedInterviewGroupView(ModelViewSet): | ||
| permission_classes = (DjangoModelPermissionsOrAnonReadOnly,) | ||
| serializer_class = RecruitmentPositionSharedInterviewGroupSerializer |
There was a problem hiding this comment.
RecruitmentSharedInterviewPositionsSerializer
backend/samfundet/views.py
Outdated
| @@ -1111,7 +1118,7 @@ def get_queryset(self) -> Response: | |||
| return Recruitment.objects.filter(visible_from__lte=timezone.now(), actual_application_deadline__gte=timezone.now()) | |||
|
|
|||
|
|
|||
| class RecruitmentInterviewGroupView(APIView): | |||
| class RecruitmentInterviewGroupRecruitmentView(APIView): | |||
There was a problem hiding this comment.
RecruitmentSharedInterviewPositionsRecruitmentView
??
| value: ( | ||
| <> | ||
| <RecruitmentInterviewGroupsList /> | ||
| <Button |
There was a problem hiding this comment.
Knappen burde være over listen. Den blir litt gjemt
| @@ -22,6 +28,19 @@ export function RecruitmentInterviewGroupComponent({ interviewGroup }: Recruitme | |||
| return { cells: [dbT(position, 'name'), dbT(position.gang, 'name')] }; | |||
| })} | |||
| /> | |||
| <div className={styles.footer}> | |||
| <Button | |||
There was a problem hiding this comment.
Fåre "something wrong" error når jeg trykker på denne. Har seeda
There was a problem hiding this comment.
Funker for meg, noe galt med din side
| import { AdminPageLayout } from '../AdminPageLayout/AdminPageLayout'; | ||
| import { RecruitmentInterviewGroupForm } from './RecruitmentInterviewGroupForm'; | ||
|
|
||
| export function RecruitmentInterviewGroupFormAdminPage() { |
There was a problem hiding this comment.
Mangler komplett breadcrumb
| positions: sharedInterview?.positions?.map((pos) => pos.id) || [], | ||
| }; | ||
|
|
||
| const title = sharedInterviewGroupId |
There was a problem hiding this comment.
Jeg føler det gir mer mening for brukeren titelen er "Opprett stillingsgruppe for felles intervju" eller lignende.
| @@ -267,7 +267,7 @@ export const nb = prepareTranslations({ | |||
| [KEY.recruitment_no_interviews]: 'Ingen intervjuer', | |||
| [KEY.recruitment_interview_set]: 'Sett intervju', | |||
| [KEY.recruitment_interview_groups]: 'Intervjugrupper', | |||
| [KEY.recruitment_interview_group]: 'Intervjugrupper', | |||
| [KEY.recruitment_interview_group]: 'Intervjugruppe', | |||
There was a problem hiding this comment.
Hva med "Opprett stillingsgruppe for felles intervju"?
| name="positions" | ||
| render={({ field }) => ( | ||
| <FormItem className={styles.item}> | ||
| <FormLabel>{`${t(KEY.common_name)} ${t(KEY.common_english)}`}</FormLabel> |
There was a problem hiding this comment.
Label burde være noe annet. F.eks. "Søk på stillingstittel"/""Search position title"
| )} | ||
| /> | ||
| </div> | ||
| <Button type="submit" rounded={true} theme="green"> |
There was a problem hiding this comment.
Ikke mulig å submite. Får toast error
first draft